Isn't the rightest part of the legend cut out if one doesn't tweak the layout (and calling plt.tight_layout() is currently even worse if I am correct)?

ah yeah that's a good point - ugh that's such annoying behavior from matplotlib :-)`

Winter Layout manager is coming (#9082)! This should help to get rid of this kind of issues if I understood correctly.

Well actually it can be gotten rid of with #9164 which is a two liner instead of 20-file fix :-).

Is the “tuple notation” really mandatory, or could the trailing coma be removed?

Same remark as before about the legend being possibly cut out.

More a note for the future: if #8292 is some day merged in (I hope so!), it would be nice to remember updating this example to include one case or two.

Maybe a dumb comment, but Line2D has already been loaded, hasn't it?

yeah here I was loading it again just so that it's easier for people to trace the imports in case they wanna do it themselves. Think it should be removed? I agree it's not standard PEP style

Well I do not know what exactly are our guidelines about this kind of things. I am not particularly pushing for removing it, I just wanted to be sure it had been done on purpose.

About PEP8, there are other imports that are not done at the top of the file anyway, so I guess that it does not really matter anyway ^^.

=> my call would be to keep it this way except if somebody more involved in the docs than I am complains ;)

I think @choldgraf might be the one most involved in the docs. 😛

@QuLogic I know ^^, but some other core devs are also quite involved about the docs and do care about what are the relevant guidelines that the docs should follow (hint: from my perspective, you are counted in that group :P)

Again, when I am trying this locally, the right part of the legend is cut out (by the figure right border).

I may be wrong but I think that one tries to use the leading zeros wherever possible: (1.05, .05) <- (1.05, 0.05)?

Similarly to previous plot:

• is the trailing coma mandatory?
• (1.05, .8) <- (1.05, 0.8)?

Similarly to previous plot:

• is the trailing coma mandatory?
• (1.05, .8) <- (1.05, 0.8)?

Purely cosmetic remark if it was not done on purpose: in the example above, there isn't a blank line after the imports but there is one before instantiating the figure, while in the current example it is the opposite

Note that the order of iteration over values()/keys() is not guaranteed (in fact it will change between iterations on Py3.4/3.5), so please use lists.

Also I think it is much better style to set the label on the artist itself:

legend_elements = [
    Line2D(..., label="foo"),
    Patch(..., label="bar)
]
ax.legend(legend_elements)

The comments apply throughout the tutorial of course.

Good point re: lists

for setting the label on the artist, IIRC doing that didn't automatically add labels when I called ax.legend but I could be wrong...

ya, when I do

legend_elements = [Line2D([0], [0], color='b', lw=4, label='Line'),
                   Line2D([0], [0], marker='o', color='w', label='Scatter',
                                     markerfacecolor='g', markersize=15),
                   Patch(facecolor='orange', edgecolor='r',
                         label='Color Patch')]
fig, ax = plt.subplots()
ax.legend(legend_elements)

the result is

is that a bug?

Of course :/, this has to be plt.legend(handles=[...]), otherwise it thinks you're passing labels for some nonexistent artists. Stupid API, refactoring it is somewhere on my (thick) todo.

Well we could do it here: #9324 I agree its a backwards API.

I would suggest having this on a separate PR. Basically, if only one positional argument is passed and it's a list of artists, then consider it as handles instead of labels.

in the meantime, I'll just use plt

hmmm, I actually just tried it w/ plt and had the same behavior...

ah nvm, I see what you mean about handles=. That works for ax.legend as well actually, but just giving it as a positional argument works for neither.

Right - the positional argument is for labels believe it or not. i.e. ax.legend({'a', 'b', 'c'}) will label the first three artists it finds on ax` 'a', 'b', and 'c'. I guess artists are stored in the order they are drawn, but it seems like a strange choice to me. Once #9324 gets merged it'll be easy to check for a list of handles instead and make the call you were trying to make work.

I understand that one kind of gave up on the idea on using out-of-axes legend before the aforementioned @jklymak's PRs are merged, but then is there a peculiar reason not to simply use loc="center" instead of loc=(0.5, 0.5). Except of course if one really want to align the lower left of the legend with the center of the axes.

nope, I'm just being dumb :-)

I think that the line above should not be here anymore, should it?

nope, will remove