FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Updated setupext.py that allows building on Mac OS X by r-owen · Pull Request #965 · matplotlib/matplotlib · GitHub

Repository navigation

Updated setupext.py that allows building on Mac OS X - #965

Merged
pelson merged 2 commits into
matplotlib:masterfrom
r-owen:master
Jun 29, 2012
Merged

pelson merged 2 commits into
matplotlib:masterfrom
r-owen:master

Conversation

r-owen commented Jun 26, 2012

Copy link
Copy Markdown
Contributor

Fix build on Mac OS X so that:

  • It "just builds" against Apple's Python using Apple's library, with no special configuration required.
  • It also looks in /usr/local. This should support HomeBrew and is used on all other platforms, so I think most users expect it.

This new setupext.py will not work with MacPorts or fink, but the old one would not either. I think it is dangerous to try to support both by default, since old or incomplete setups could lead to including unexpected libraries.

r-owen added 2 commits March 1, 2012 14:12
include instructions for users of packaging systems (e.g. MacPorts).

pelson commented Jun 27, 2012

Copy link
Copy Markdown
Member

+1 from me. The discussion on #168 is the relevant background information.

jswhit commented Jun 27, 2012

Copy link
Copy Markdown

Not having it look for fink and macports packages is fine - if you have one of those you can just use their matplotlib packages.

pelson commented Jun 28, 2012

Copy link
Copy Markdown
Member

@jdh2358: I have been able to test this successfully on OSX 10.7 with both homebrew and apple Python 2.7. @r-owen has tested on 10.6. Do you know who else should see this before I commit?

@efiring: I know you were involved in the original discussion. Do you have any objections to this change?

efiring commented Jun 28, 2012

Copy link
Copy Markdown
Member

No objection. Let's try it and see what happens.

Copy link
Copy Markdown
Member

+1 (though cannot test now, travelling)

I think the big reason for recommending make.osx is all the build problems you get when setupext picks up incompatible versions of libraries, so reducing the number of directories it looks in should help. I think if /usr or /usr/X11 has a version of freetype that's incompatible with /usr/bin/python, it's an Apple bug, but people could have installed whatever libraries in /usr/local (perhaps indirectly - .pkg installers can leave stuff all over your system). Does the output from "python setup.py build" indicate which directories each dependency is found in? That information could help when people report build problems.

pelson commented Jun 29, 2012

Copy link
Copy Markdown
Member

Does the output from "python setup.py build" indicate which directories each dependency is found in?

No. But it looks like the setupext could be made to do so with a bit of effort if we did want that ability. I'm going to merge this issue, but will open a subsequent issue for getting the path info for some of the build dependencies.

pelson added a commit that referenced this pull request Jun 29, 2012
Updated setupext.py that allows building on Mac OS X
pelson merged commit a720fd7 into matplotlib:master Jun 29, 2012
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL