FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "Axes.__init__ speedup" by dstansby · Pull Request #9718 · matplotlib/matplotlib · GitHub

Repository navigation

Revert "Axes.__init__ speedup" - #9718

Merged
Kojoley merged 1 commit into
masterfrom
revert-8626-Axes-init-speedup
Nov 8, 2017
Merged

Kojoley merged 1 commit into
masterfrom
revert-8626-Axes-init-speedup

Conversation

dstansby commented Nov 8, 2017

Copy link
Copy Markdown
Member

Reverts #8626, because it broke lots of stuff on master: https://travis-ci.org/matplotlib/matplotlib/builds/298909059

Kojoley commented Nov 8, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

I have triggered an additional build on master to see if the problem persistent https://travis-ci.org/matplotlib/matplotlib/builds/299098042
Update: Yes, it is.

Kojoley merged commit f2afc4c into master Nov 8, 2017
Kojoley deleted the revert-8626-Axes-init-speedup branch November 8, 2017 14:23

efiring commented Nov 8, 2017

Copy link
Copy Markdown
Member

Specifically, it broke polar plot tests. Originally it was passing, so either the tests are new, or the changes in polar plotting in the interim are interacting badly with this change. Attn @QuLogic

QuLogic added this to the v2.2 milestone Nov 8, 2017

QuLogic commented Nov 8, 2017

Copy link
Copy Markdown
Member

Some of the tests are old, so it's probably something in the new polar options that is broken. I remember having to add seemingly-superfluous reset_ticks, so there's probably some other path that's missing the right trigger.

QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL