FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

FIX/TST: update tests for pandas 0.21 by jklymak · Pull Request #9726 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

FIX/TST: update tests for pandas 0.21 - #9726

Merged
story645 merged 1 commit into
matplotlib:masterfrom
jklymak:fixpandas
Nov 10, 2017
ConversationCommits (1)ChecksFiles changed
Merged

FIX/TST: update tests for pandas 0.21#9726
story645 merged 1 commit into
matplotlib:masterfrom
jklymak:fixpandas

Conversation

jklymak commented Nov 9, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

This should fix #9610.

As of pandas 0.21, import pandas no longer calls

from pandas.tseries import converter
converter.register()

so it has been added to the tests.

Surprisingly no examples depend on pandas, so that made life simpler.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant

jklymak added this to the v2.1.1 milestone Nov 9, 2017
jklymak added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Nov 9, 2017
dstansby reviewed Nov 9, 2017
View reviewed changes
Comment thread lib/matplotlib/tests/test_axes.py
pd = pytest.importorskip('pandas')
from pandas.tseries import converter
converter.register()

dstansby Nov 9, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

PEP8 doesn't like this blank line, otherwise tests seem to be fine.

jklymak mentioned this pull request Nov 9, 2017
Closed

story645 commented Nov 9, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

so unclear if this code actually reduces coverage or if it's an artifact of a different PR.

dstansby commented Nov 9, 2017

Copy link
Copy Markdown
Member

Sometimes I feel like I need an undergraduate degree in codecov just to understand codecov...

I think the issue is that there are two tests both named test_pandas_bar_align_center() so only one is collected and run. @jklymak would you mind quickly changing the name of one of them here?

jklymak commented Nov 9, 2017

Copy link
Copy Markdown
Member Author

Huh, did I do that? Anyhow, should be fixed now barring other foolishness

dstansby approved these changes Nov 9, 2017
View reviewed changes

dstansby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍 happy for this to go in once tests pass - at least now we can start testing on latest version of pandas again whilst discussing what to do about unit support

story645 merged commit 91e4bee into matplotlib:master Nov 10, 2017

tacaswell commented Nov 10, 2017

Copy link
Copy Markdown
Member

@meeseeksdev backport to v2.1.x

lumberbot-app Bot commented Nov 10, 2017

Copy link
Copy Markdown

There seem to be a conflict, please backport manually

tacaswell pushed a commit that referenced this pull request Nov 10, 2017
Merge pull request #9726 from jklymak/fixpandas
ce45bea 
FIX/TST: update tests for pandas 0.21

Conflicts:
    .appveyor.yml
       conflicts due thrashing around pandas version pinning

tacaswell commented Nov 10, 2017

Copy link
Copy Markdown
Member

manually backported via ce45bea

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dstansby dstansby approved these changes

Assignees

No one assigned

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: testing

Projects

None yet

Milestone

v2.1.1

Development

Successfully merging this pull request may close these issues.

provide converters for datetime64 types

4 participants

Back | FazBrowse Home | New Git URL