Repository navigation
Polar tick fixes - #9881
Merged
dopplershift merged 6 commits intoDec 1, 2017
Merged
Polar tick fixes#9881dopplershift merged 6 commits into
dopplershift merged 6 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Because of the resetting and the ways tick anchoring worked, this was effectively how it worked anyway.
The anchor needs to be on the opposite side compared to counterclockwise plots.
They ended up upside down because of the negative angle after accounting for axis direction. The normalization should work for clockwise plots and those that start with any arbitrary start offset.
These don't really seem to be necessary anymore with previous fixes.
tacaswell
approved these changes
Dec 1, 2017
dopplershift
approved these changes
Dec 1, 2017
dstansby
added a commit
that referenced
this pull request
Dec 2, 2017
Backport PR #9881 on branch v2.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This fixes several issues with ticks on polar plots, mostly when using clockwise orientation. I have tentatively put this on 2.1.1 as it is mostly a bug fix, but I'm 50/50 on the last commit. It's still a fix for something, just a little more magic than the others.
PR Checklist