FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

BUG: clear events before destroying windows in tkagg by mattip · Pull Request #9956 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

BUG: clear events before destroying windows in tkagg - #9956

Merged
tacaswell merged 1 commit into
matplotlib:masterfrom
mattip:tkagg-issue9856
Dec 13, 2017
ConversationCommits (1)ChecksFiles changed
Merged

BUG: clear events before destroying windows in tkagg#9956
tacaswell merged 1 commit into
matplotlib:masterfrom
mattip:tkagg-issue9856

Conversation

mattip commented Dec 8, 2017

Copy link
Copy Markdown
Contributor

Fixes issue #9856 by clearing events while destroying.

Alternative implementation: call flush_events() in close_events() in FigureCanvasAgg, which might help other backends?

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

mattip commented Dec 8, 2017

Copy link
Copy Markdown
Contributor Author

There seem to be a number of issues related to TkAgg and the message loop: #9856, #8129, #9077, #8845.
Since AFAICT pull requests #9275, #9356 seem to be approved, could they be merged to master? It would make determining how this pull request affects the other issues easier.

mattip mentioned this pull request Dec 8, 2017
Closed

jklymak commented Dec 8, 2017

Copy link
Copy Markdown
Member

This works fine for me on OS X, with no unsightly messages.

tacaswell added this to the v2.2 milestone Dec 8, 2017

anntzer commented Dec 9, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is not fixed by #9275 (dunno, just asking)?

jklymak commented Dec 9, 2017

Copy link
Copy Markdown
Member

No. I was testing off master and got those errors

duynguyenhoang commented Dec 11, 2017

Copy link
Copy Markdown

Fixed #9856 for me
get_backend() == TkAgg
MacOS 10.12.6
Python 3.6.2

anntzer mentioned this pull request Dec 11, 2017
Merged
1 of 6 tasks
tacaswell merged commit 2132073 into matplotlib:master Dec 13, 2017

tacaswell commented Dec 13, 2017

Copy link
Copy Markdown
Member

May not be the perfect solution, but is an improvement over status-quo.

QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
mattip deleted the tkagg-issue9856 branch February 15, 2018 23:07
mattip mentioned this pull request Oct 29, 2018
Closed
richardsheridan mentioned this pull request Jun 29, 2020
Merged
5 of 6 tasks
richardsheridan mentioned this pull request Sep 27, 2020
Merged
4 of 7 tasks
richardsheridan mentioned this pull request Jun 23, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jklymak jklymak approved these changes

Assignees

No one assigned

Labels

GUI: tk

Projects

None yet

Milestone

v2.2.0

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL