FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove inventory redirect by tacaswell · Pull Request #67 · matplotlib/matplotlib.github.com · GitHub

Remove inventory redirect - #67

Open
tacaswell wants to merge 1 commit into
matplotlib:gh-pagesfrom
tacaswell:inventory_redirect
Open

tacaswell wants to merge 1 commit into
matplotlib:gh-pagesfrom
tacaswell:inventory_redirect

Conversation

Copy link
Copy Markdown
Member

Per discussion in
matplotlib/matplotlib#22601 (comment)
this is actually breaking builds in subtle very brittle way as the links that
will be generated will be pointing at the top-level files (that are actually
re-directs to /stable).

The second step of this will be to put a 301 redirect into caddy.

Per discussion in
matplotlib/matplotlib#22601 (comment)
this is actually breaking builds in subtle very brittle way as the links that
will be generated will be pointing at the top-level files (that are actually
re-directs to /stable).

The second step of this will be to put a 301 redirect into caddy.

QuLogic commented Mar 10, 2022

Copy link
Copy Markdown
Member

We're actually serving from main there, though we could switch to gh-pages.

tacaswell changed the base branch from gh-pages to main March 10, 2022 22:52

Copy link
Copy Markdown
Member Author

Changed the bass branch. From reading the ansible (~L95) where we do the checkouts all of the repos go to gh-pages so I thought we were doing gh-pages everywhere.

QuLogic commented Mar 10, 2022

Copy link
Copy Markdown
Member

Yea, they're currently in sync, so I was a bit lazy with writing the Ansible, but that's not what's currently being served.

Copy link
Copy Markdown
Member Author

Given that the caddy configuration seems to be taking precedence anyway, this is a pretty low priority to get done (mostly to avoid confusing future us).

tacaswell changed the base branch from main to gh-pages April 18, 2022 15:07

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL