fix: enforce type-safe value in setCellStyles by redfish4ktc · Pull Request #1028 · maxGraph/maxGraph · GitHub

This is a WIP

description for enforce type-safe value in setCellStyles
Previously, any value type could be passed for any style key without compile-time error, allowing bugs like passing a string for a boolean property.
Using a generic constraint ensures the value type matches the key's declared type in CellStateStyle, catching mismatches at compile
time.

Tasks

Increase the scope of this PR:

add tests to the code which is going to be updated
improve the explanation in https://github.com/maxGraph/maxGraph/pull/1026/changes#r2986999100. Add direct link to the source code, link to commit are unpracticable as there are too many files involved and this is hard to display in the GH web UI

Fix the default value to true in

maxGraph/packages/core/src/view/mixin/ConnectionsMixin.ts

Lines 170 to 175 in 24357a7

    
           let perimeter = false; 
        
           let dx = 0; 
        
           let dy = 0; 
        
           if (point) { 
        
             perimeter = edge.style[source ? 'exitPerimeter' : 'entryPerimeter'] || false;

refactor the code of

maxGraph/packages/core/src/view/mixin/ConnectionsMixin.ts

Lines 202 to 206 in 24357a7

    
           // Only writes 0 since 1 is default 
        
           if (!constraint.perimeter) { 
        
             this.setCellStyles(source ? 'exitPerimeter' : 'entryPerimeter', '0', [edge]); 
        
           } else { 
        
             this.setCellStyles(source ? 'exitPerimeter' : 'entryPerimeter', null, [edge]);

to have a single call to this.setCellStyles

Other tasks

improve the PR description. Not really a breaking change as wrong values leads to bug

This is a breaking change for any consumer calling setCellStyles with a value that does not match the type of the specified key. These calls were already semantically incorrect — the stricter type now surfaces the error at compile time.

Notes

Covers #840
Should be merged after #1026

Previously, any value type could be passed for any style key without compile-time error, allowing bugs like passing a string for a boolean property. Using a generic constraint ensures the value type matches the key's declared type in CellStateStyle, catching mismatches at compile time.

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d7675152-6b7f-417b-ab4b-76b5afbe6dbd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Quality Gate failed

Failed conditions
17.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

suggestion: the type of the value parameter should be a boolean.Do we allow undefined?

suggestion: the type of the value parameter should be a boolean. Do we allow undefined?

suggestion: there is a duplication here, the value is not the same depending on the result of the if condition, but the rest of the implementation is the same.

nitpick: adapt this comment (use boolean instead of number)

redfish4ktc added the bug Something isn't working label Mar 24, 2026

tbouffard mentioned this pull request Mar 24, 2026

fix(connectionHandler): apply perimeter style to new edges #1026

Merged

7 tasks

redfish4ktc added 2 commits March 25, 2026 10:15

CellStateStyle: improve JSDoc (entryX, entryY)

2881f67

fix test

d947eeb

redfish4ktc commented Apr 8, 2026

View reviewed changes

@@ @@ -241,14 +241,14 @@ class GraphLayout { @@
                  * Disables or enables the edge style of the given edge.
                  */
                 setEdgeStyleEnabled(edge: Cell, value: any): void {

                  */
                 setOrthogonalEdge(edge: Cell, value: any): void {
-                  this.graph.setCellStyles('orthogonal', value ? '1' : '0', [edge]);
+                  this.graph.setCellStyles('orthogonal', !!value, [edge]);

fix: enforce type-safe value in setCellStyles by redfish4ktc · Pull Request #1028 · maxGraph/maxGraph · GitHub

Uh oh!

fix: enforce type-safe value in setCellStyles - #1028

fix: enforce type-safe value in setCellStyles#1028
redfish4ktc wants to merge 3 commits into
mainfrom
refactor/improve_signature_types_setCellStyles

redfish4ktc commented Mar 24, 2026 •
edited
Loading

Uh oh!

Uh oh!

coderabbitai Bot commented Mar 24, 2026 •
edited
Loading

Uh oh!

Uh oh!

sonarqubecloud Bot commented Mar 25, 2026

Uh oh!

redfish4ktc Apr 8, 2026

Uh oh!

redfish4ktc Apr 8, 2026

Uh oh!

redfish4ktc Apr 8, 2026

Uh oh!

redfish4ktc Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	let perimeter = false;
	let dx = 0;
	let dy = 0;

	if (point) {
	perimeter = edge.style[source ? 'exitPerimeter' : 'entryPerimeter'] \|\| false;

	// Only writes 0 since 1 is default
	if (!constraint.perimeter) {
	this.setCellStyles(source ? 'exitPerimeter' : 'entryPerimeter', '0', [edge]);
	} else {
	this.setCellStyles(source ? 'exitPerimeter' : 'entryPerimeter', null, [edge]);

		@@ -201,7 +201,9 @@ export const ConnectionsMixin: PartialType = {

		// Only writes 0 since 1 is default

fix: enforce type-safe value in setCellStyles by redfish4ktc · Pull Request #1028 · maxGraph/maxGraph · GitHub

Uh oh!

fix: enforce type-safe value in setCellStyles - #1028

fix: enforce type-safe value in setCellStyles#1028redfish4ktc wants to merge 3 commits intomainmaxGraph/maxGraph:mainfrom refactor/improve_signature_types_setCellStylesmaxGraph/maxGraph:refactor/improve_signature_types_setCellStylesCopy head branch name to clipboard

Conversation

redfish4ktc commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tasks

Notes

Uh oh!

coderabbitai Bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

sonarqubecloud Bot commented Mar 25, 2026

Quality Gate failed

Uh oh!

redfish4ktc Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

redfish4ktc Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

redfish4ktc Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

redfish4ktc Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

fix: enforce type-safe value in setCellStyles#1028
redfish4ktc wants to merge 3 commits into
mainfrom
refactor/improve_signature_types_setCellStyles

redfish4ktc commented Mar 24, 2026 •
edited
Loading

coderabbitai Bot commented Mar 24, 2026 •
edited
Loading