Repository navigation
chore(claude): make collect-media.sh executable - #1220
redfish4ktc merged 1 commit into
Conversation
Sorry, something went wrong.
The prepare-release skill runs .claude/skills/prepare-release/collect-media.sh directly, but the script was committed with mode 100644, so the call fails with "Permission denied" and the media of the highlights are not collected. The bit was lost because core.fileMode is false in the clone the script was written in: git then ignores the mode on disk, and a chmod +x never reaches the index. The mode is set with git update-index --chmod=+x instead, which records it whatever core.fileMode says.
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
Reviewing files that changed from the base of the PR and between 25f9646 and cd81c52. 📒 Files selected for processing (1)
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file. Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
|
Sorry, something went wrong.
The prepare-release skill calls .claude/skills/prepare-release/collect-media.sh directly, but the script was committed with mode 100644, so the call fails with Permission denied and the media of the highlights are not collected. This was met while preparing 0.25.0, where the script had to be run through bash instead.
The mode is now 100755. It was set with git update-index --chmod=+x: the clone the script was written in has core.fileMode set to false, so git ignores the mode on disk and a plain chmod +x never reaches the index.
No content change, the diff is the mode only.