New pinch touch zoom [draft] - #149
Draft
mcyph wants to merge 14 commits into
Draft
Conversation
…ler to allow use in touch story example
…made it so mousemove/pointermove events are ignored when there's multitouch and addMouseWheelListener enabled
tbouffard
reviewed
Jan 13, 2026
Comment thread
packages/core/src/view/event/InternalEvent.ts
| const getTouchDistance = (touches: TouchArray) => { | ||
| const a = touches[0].clientX - touches[1].clientX; | ||
| const b = touches[0].clientY - touches[1].clientY; | ||
| return Math.sqrt(a * a + b * b); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
suggestion: use Math.hypot instead (perform the same calculation)
Sorry, something went wrong.
tbouffard
reviewed
Jan 13, 2026
Comment thread
packages/core/src/view/event/InternalEvent.ts
|
|
||
| InternalEvent.addListener(target, 'gesturechange', ((evt: GestureEvent) => { | ||
| InternalEvent.consume(evt); | ||
| const getTouchDistance = (touches: TouchArray) => { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
suggestion: move this closure out of the enclosing function as it doesn't depend on any state provided by this function
Sorry, something went wrong.
Comment thread
packages/core/src/view/event/InternalEvent.ts
|
|
||
| if (typeof evt.scale === 'number') { | ||
| const diff = scale - evt.scale; | ||
| const touchesToArray = (touches: TouchList): TouchArray => { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
suggestion: move this closure out of the enclosing function as getTouchDistance.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes jumpy multitouch zooming on Android, and restores the touch example by converting it to StoryBook and ES6 classes.
More details/caveats of this PR are in the comment at #62 (comment).
Description for the changelog
Resolves #62.