FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(editor): ensure editor context in installDblClickHandler callback by tbouffard · Pull Request #934 · maxGraph/maxGraph · GitHub

/ maxGraph Public
forked from jgraph/mxgraph

fix(editor): ensure editor context in installDblClickHandler callback #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbouffard merged 2 commits into from
Oct 31, 2025
+35 −3
Conversation 2 Commits 2 Checks 6 Files changed 2
Merged

fix(editor): ensure editor context in installDblClickHandler callback #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
421b038
fix(editor): ensure editor context in installDblClickHandler callback
tbouffard Oct 31, 2025
41b1e48
simplify test code
tbouffard Oct 31, 2025
File filter

Filter by extension

Filter by extension .ts  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
33 changes: 32 additions & 1 deletion packages/core/__tests__/editor/Editor.test.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ limitations under the License.
*/

import { describe, expect, test } from '@jest/globals';
import { Editor, Geometry } from '../../src';
import { Editor, Geometry, EventObject, InternalEvent } from '../../src';
import { ModelChecker } from '../serialization/utils';
import { parseXml } from '../../src/util/xmlUtils';
import Cell from '../../src/view/cell/Cell';
Expand Down Expand Up @@ -138,3 +138,34 @@ describe('cycleAttribute', () => {
expect(cell.getStyle()).toEqual(originalStyle);
});
});

describe('installDblClickHandler', () => {
test('double-click handler has correct editor context', () => {
const editor = new Editor(null!);
const mockExecute = jest.fn();
editor.execute = mockExecute;
editor.dblClickAction = 'testAction';

// Create a container element for the graph
const container = document.createElement('div');
document.body.appendChild(container);
editor.setGraphContainer(container);

// Create a test cell
const cell = editor.graph.insertVertex({
value: 'test',
position: [10, 10],
size: [100, 100],
});

// Fire the DOUBLE_CLICK event with proper EventObject
const eventObj = new EventObject(InternalEvent.DOUBLE_CLICK, { cell, event: {} });
editor.graph.fireEvent(eventObj);

// Verify that execute was called on the editor instance with the correct action and cell
expect(mockExecute).toHaveBeenCalledWith('testAction', cell);

// Clean up
container.remove();
});
});
5 changes: 3 additions & 2 deletions packages/core/src/editor/Editor.ts
Show comments Show annotations
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -1532,12 +1532,13 @@
* @param graph
*/
installDblClickHandler(graph: AbstractGraph): void {
const editor = this;

Check warning on line 1535 in packages/core/src/editor/Editor.ts

View workflow job for this annotation

GitHub Actions / build (ubuntu-24.04) 

Unexpected aliasing of 'this' to local variable

Check warning on line 1535 in packages/core/src/editor/Editor.ts

View workflow job for this annotation

GitHub Actions / build (macos-14) 

Unexpected aliasing of 'this' to local variable

Check warning on line 1535 in packages/core/src/editor/Editor.ts

View workflow job for this annotation

GitHub Actions / build (windows-2022) 

Unexpected aliasing of 'this' to local variable
// Installs a listener for double click events
graph.addListener(InternalEvent.DOUBLE_CLICK, (sender: any, evt: EventObject) => {
const cell = evt.getProperty('cell');

if (cell != null && graph.isEnabled() && this.dblClickAction != null) {
this.execute(this.dblClickAction, cell);
if (cell != null && graph.isEnabled() && editor.dblClickAction != null) {
editor.execute(editor.dblClickAction, cell);
evt.consume();
}
});
Expand Down
Back | FazBrowse Home | New Git URL