chore: build with node 24 - #971
Merged
tbouffard merged 3 commits intoDec 10, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
WalkthroughUpdated Node.js version in .nvmrc from 22 to 24 and made minor documentation edits (Build & Development Environment guidance) in .github/copilot-instructions.md and CLAUDE.md. No functional code changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
📜 Recent review details Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📥 CommitsReviewing files that changed from the base of the PR and between 8082698 and 612d674. 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands and usage tips. |
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review detailsConfiguration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 CommitsReviewing files that changed from the base of the PR and between 1be0a47 and 8082698.
📒 Files selected for processing (1)- .nvmrc (1 hunks)
Learnt from: CR Repo: maxGraph/maxGraph PR: 0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-12-04T15:34:46.016Z Learning: ALWAYS use Node.js version 20 (specified in .nvmrc). Verify with 'node --version' which should show v20.x.x. This is the version used in CI/CD.
Learnt from: CR Repo: maxGraph/maxGraph PR: 0 File: CLAUDE.md:0-0 Timestamp: 2025-12-04T15:35:02.405Z Learning: Use Node.js version from .nvmrc file via nvm use command
Learnt from: tbouffard Repo: maxGraph/maxGraph PR: 849 File: packages/html/stories/DragSource.stories.js:98-101 Timestamp: 2025-06-13T07:48:10.300Z Learning: User tbouffard prefers answers in English; avoid switching to other languages in future replies.
Learnt from: CR Repo: maxGraph/maxGraph PR: 0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-12-04T15:34:46.016Z Learning: ALWAYS use Node.js version 20 (specified in .nvmrc). Verify with 'node --version' which should show v20.x.x. This is the version used in CI/CD.
Applied to files:
- .nvmrc
- GitHub Check: build (macos-14)
- GitHub Check: build
- GitHub Check: build (ubuntu-24.04)
- GitHub Check: build (windows-2022)
Sorry, something went wrong.
Comment thread
.nvmrc
Copy link
Copy Markdown
|
Sorry, something went wrong.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mainly to use npm 11 which is required to use trusted publishers during npm publish.
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.