docs: the verification found the packaged toolset could not link a default build - #435
Merged
Sunrisepeak merged 2 commits intoAug 16, 2026
Merged
docs: the verification found the packaged toolset could not link a default build#435Sunrisepeak merged 2 commits into
Sunrisepeak merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…fault build Not a planned item -- it turned up while working through the "not covered" list, checking whether the packaged 14.52 could build xrgui. It could not, and neither could it build anything else: the payload set carried only the static CRT, so /MD (the default) failed on an unresolved msvcprt.lib. Fixed in xim-pkgindex#630. Recorded here because of what it says about the acceptance table in §4: "1790 static checks pass" and "windows-test installs it on a real Windows runner" were both true while the toolchain was broken. `installed()` checked cl.exe and std.ixx, and nothing anywhere links with this toolset -- so no gate could have reported it. An "installed" criterion weaker than "usable" reports that the archive unpacked, not that the package works.
…et that never appeared `toolchain list` asked for `root/bin`; msvc keeps cl.exe four levels deeper. Three places need that layout, two had it. Fixed in #436. Recorded here for how it was found: not by a test. The unit test written for this pinned `identify_xim_payload("msvc")`, which was already correct -- identity mapping and enumeration are different questions and only one was being asked. e2e 239 step 1b would catch it, but only once the package is published and the Windows e2e runs again. "Has a test" and "has been tested" are not the same thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Not a planned item — it turned up while working through the "not covered" list in the cross-repo plan, checking whether the packaged 14.52 toolset could build xrgui. It could not, and neither could it build anything else.
The payload set carried only the static CRT (libcmt / libcpmt / libvcruntime), so /MD — the default — failed on an unresolved msvcprt.lib. The header decides:
Fixed in openxlings/xim-pkgindex#630 (the libs live in Microsoft.VC.<ver>.CRT.x64.Store.base — a name that reads as UWP, which is why it was skipped).
Why it belongs in this doc
Because of what it says about the acceptance table in §4. Both of these were true at the same time as the toolchain being unusable:
installed() checked cl.exe and std.ixx — both present — and nothing anywhere links with this toolset, so no gate could have reported it.
The "not covered" section is renumbered and gains the honest version of this: strengthening installed() makes file presence stricter, which is not the same as links successfully. Only xrgui's V3 covers that, and it has not run yet.
Test plan