Refactor merge underlying submodule - #22
Merged
FrozenLemonTee merged 2 commits intoMar 27, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: FrozenlemonTee <1115306170@qq.com>
…derlying module directly Signed-off-by: FrozenlemonTee <1115306170@qq.com>
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the mcpplibs.primitives.underlying module by merging the former underlying.traits (and the trivial underlying.impl) submodules into a single module interface, and updates internal imports accordingly.
Changes:
- Move/export all underlying traits, categories, and concepts directly from mcpplibs.primitives.underlying.
- Remove the standalone mcpplibs.primitives.underlying.traits and mcpplibs.primitives.underlying.impl modules.
- Update affected modules to import mcpplibs.primitives.underlying instead of the removed submodule.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file| File | Description |
|---|---|
| src/underlying/underlying.cppm | Becomes the single exported interface containing underlying traits/concepts previously in submodules. |
| src/underlying/traits.cppm | Deleted after being merged into underlying.cppm. |
| src/underlying/impl.cppm | Deleted (was effectively a re-export-only module). |
| src/literals/literals.cppm | Switch import from ...underlying.traits to ...underlying. |
| src/algorithms/limits.cppm | Switch import from ...underlying.traits to ...underlying. |
Sorry, something went wrong.
Comment thread
src/underlying/underlying.cppm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.