Refactor CMake configuration to ensure successful tests building using CMake and improve test organization (fix PR#2) - #3
Open
FrozenLemonTee wants to merge 16 commits into
Open
Refactor CMake configuration to ensure successful tests building using CMake and improve test organization (fix PR#2)#3FrozenLemonTee wants to merge 16 commits into
FrozenLemonTee wants to merge 16 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
… version not found in mapping
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
Adds/reshapes the project’s test/build setup to better support C++23 modules and GoogleTest under both xmake and CMake/CTest, including a version→UUID mapping for import std.
Changes:
- Move xmake test target definition into tests/main/ and include it from tests/xmake.lua.
- Introduce CMake-based test infrastructure (tests/CMakeLists.txt, tests/main/CMakeLists.txt) with GTest discovery/fetch and CTest registration.
- Update top-level CMakeLists.txt to add compiler/CMake gating and to configure CMAKE_EXPERIMENTAL_CXX_IMPORT_STD via cmake_import_std_uuids.json.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file| File | Description |
|---|---|
| tests/xmake.lua | Replaces inline test target with includes("main"). |
| tests/main/xmake.lua | New xmake test target definition under tests/main. |
| tests/main/main.cpp | New GTest test and custom main() for running tests. |
| tests/main/CMakeLists.txt | New CMake test executable and CTest registration. |
| tests/CMakeLists.txt | New GTest find-or-fetch logic and adds tests/main. |
| CMakeLists.txt | Adds CMake/compiler version logic and CTest-based test inclusion. |
| cmake_import_std_uuids.json | Adds mapping for CMAKE_EXPERIMENTAL_CXX_IMPORT_STD UUID by CMake version. |
| .gitignore | Ignores IDE/cache directories. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Sorry, something went wrong.
Comment thread
CMakeLists.txt
Comment on lines
+35
to
+41
| if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS ${COMPILER_MSVC_VERSION_MINIMUM}) | ||
| message(FATAL_ERROR | ||
| "MSVC version too old for C++ Modules.\n" | ||
| "MSVC version: ${CMAKE_CXX_COMPILER_VERSION} (>= ${COMPILER_MSVC_VERSION_MINIMUM} X)" | ||
| ) | ||
| else() | ||
| message(STATUS "MSVC version: ${CMAKE_CXX_COMPILER_VERSION} (>= ${COMPILER_MSVC_VERSION_MINIMUM} ✓)") |
Comment thread
tests/main/CMakeLists.txt
| set(TEST_EXECUTABLE_NAME main_tests) | ||
| add_executable(${TEST_EXECUTABLE_NAME} ${TESTS_SRC}) | ||
|
|
||
| target_link_libraries(${TEST_EXECUTABLE_NAME} PRIVATE GTest::gtest GTest::gmock GTest::gmock_main GTest::gtest_main) |
Comment thread
CMakeLists.txt
Comment on lines
+5
to
+16
| # Compiler version check | ||
| if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU") | ||
| if (WIN32) | ||
| message(FATAL_ERROR | ||
| "Detected the use of MinGW GCC compiler on Windows.\n" | ||
| "MinGW GCC has serious compatibility issues with C++23 modules (import std).\n" | ||
| "Please switch to Clang (such as llvm-mingw) or MSVC for compilation." | ||
| ) | ||
| endif () | ||
| set(COMPILER_GCC_VERSION_MINIMUM 14.0) | ||
| if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS ${COMPILER_GCC_VERSION_MINIMUM}) | ||
| message(FATAL_ERROR |
Comment thread
tests/CMakeLists.txt
Comment on lines
+3
to
+7
| if(NOT TARGET GTest::gtest) | ||
| find_package(GTest QUIET CONFIG) | ||
| endif() | ||
|
|
||
| if(NOT TARGET GTest::gtest) |
Sunrisepeak
force-pushed
the
main
branch
3 times, most recently
from
884d640 to
649afbd
Compare
May 24, 2026 00:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.