Update support info for Node.js support of AbortSignal - #17418
Merged
queengooborg merged 5 commits intoAug 20, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
queengooborg
requested changes
Aug 20, 2022
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Hey @aduh95, thank you for your PR! It looks like the feature was also backported to 16.14.0. Could we create two separate release statements to represent this, like so?
{
"nodejs": [
{
"version_added": "17.2.0",
},
{
"version_added": "16.14.0",
"version_removed": "17.0.0",
}
]
}
Sorry, something went wrong.
queengooborg
approved these changes
Aug 20, 2022
queengooborg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thank you, LGTM!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Data was wrong (it showed no support on the Node.js cell, when it fact Node.js does support it), so I updated it to be conform to reality.
Test results and supporting details
Related issues