Container: Add initial container for meshtastic-cli - #847
Conversation
Sorry, something went wrong.
|
|
Sorry, something went wrong.
ianmcorvidae
left a comment
There was a problem hiding this comment.
One small comment, but in general I think this is good. I haven't actually tested the containerfiles myself but they look like they should work fine and hopefully you did, anyway!
Sorry, something went wrong.
| tags: | ||
| - 'v*' |
There was a problem hiding this comment.
We don't use the v prefix for the tags in this repo -- https://github.com/meshtastic/python/tags
I imagine this should probably just build on any tag, or any three-part numeric thing that looks like a version number.
Sorry, something went wrong.
There was a problem hiding this comment.
good catch, I admit i didn't double check! I'll remove that and check.
And yes, I did test them as I actually needed the CLI without wanting to install everything :p
but the 'v*' is just a just an easy way to only do this (and publish) for tagged releases, I'll also double check if we can filter on 'digit(s).digit(s).digit(s) but I don't think so, as I would have probably added at least one digit after the 'v' so we could do
- '*.*.*' maybe?
Sorry, something went wrong.
| !extra/ | ||
| !meshtastic/ | ||
| !poetry.lock | ||
| !protobufs/ |
There was a problem hiding this comment.
I can go either way on this, but if this is just for running the CLI itself, we probably don't need to worry about including the protobufs folder. It's really only used as an input for the update-protobufs script that builds actual python stuff in meshtastic/protobuf. If you think it's more useful to include it I don't have a problem with it though.
Sorry, something went wrong.
Just a quick set of files to enable the build of (tagged) containers. Both alpine and debian containers are available (~200MiB/~1.2GiB) allowing us to use meshtastic cli with a quick docker run, instead of having to build/install stuff locally. Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
|
Sorry for taking so long on this. I'm going to give it a good look and maybe harden some of our CI stuff as well, but probably I'll merge this shortly. Thanks for the contribution! |
Sorry, something went wrong.
Just a quick set of files to enable the build of (tagged) containers. Both alpine and debian containers are available (~200MiB/~1.2GiB) allowing us to use meshtastic cli with a quick docker run, instead of having to build/install stuff locally.