Fix traceroute timeout for case of 0-hops - #871
Merged
ianmcorvidae merged 2 commits intoMar 2, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
It was not waiting any time.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts traceroute timeout calculation so traceroute requests don’t immediately time out in low-hop scenarios (notably when the configured hop limit is 0).
Changes:
- Updates the traceroute wait factor calculation to use hopLimit + 1 when capping the timeout multiplier.
Sorry, something went wrong.
Comment thread
meshtastic/mesh_interface.py
Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #871 +/- ##
==========================================
+ Coverage 59.88% 60.59% +0.70%
==========================================
Files 24 24
Lines 4318 4337 +19
==========================================
+ Hits 2586 2628 +42
+ Misses 1732 1709 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was not waiting any time.