FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Add ESP32 WiFi Unified OTA update support by skgsergio · Pull Request #898 · meshtastic/python · GitHub

/ python Public

feat: Add ESP32 WiFi Unified OTA update support - #898

Merged
ianmcorvidae merged 5 commits into
meshtastic:masterfrom
skgsergio:feat/esp32-unified-ota
Mar 2, 2026
ConversationCommits (5)ChecksFiles changed
Merged

feat: Add ESP32 WiFi Unified OTA update support#898
ianmcorvidae merged 5 commits into
meshtastic:masterfrom
skgsergio:feat/esp32-unified-ota

Conversation

skgsergio commented Jan 31, 2026

Copy link
Copy Markdown
Contributor

Added ESP32 WiFi Unified OTA update support.

Did not include BLE support as I didn't manage to connect to a device via BLE. I have a draft (AI-generated, because I know little about BLE and its libraries) for BLE, but I'm not going to commit something I can't review and test properly.

Related to #895

CLAassistant commented Jan 31, 2026 •
edited
Loading

Copy link
Copy Markdown


All committers have signed the CLA.

CLAassistant commented Jan 31, 2026

Copy link
Copy Markdown


Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

skgsergio force-pushed the feat/esp32-unified-ota branch from 8b314bf to 9b2b0bd Compare January 31, 2026 15:42
skgsergio force-pushed the feat/esp32-unified-ota branch from 9b2b0bd to 1eb13c9 Compare January 31, 2026 15:44
Copilot AI reviewed Jan 31, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Implements ESP32 WiFi Unified OTA support in the Python CLI and library so ESP32 nodes can be updated over WiFi/TCP without the Android app.

Changes:

  • Added ESP32WiFiOTA helper in meshtastic/ota.py to compute firmware hashes and drive the Unified OTA TCP protocol.
  • Extended Node with a startOTA() admin helper to request OTA mode using the new OTAEvent fields.
  • Wired a new --ota-update CLI option in meshtastic.__main__ that triggers WiFi OTA for ESP32 nodes (firmware ≥ 2.7.18) over a TCP connection.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
meshtastic/ota.py Introduces the ESP32WiFiOTA class that connects to the node’s OTA TCP server, sends size/hash metadata, and streams firmware with basic progress reporting and status handling.
meshtastic/node.py Adds startOTA() on Node to populate AdminMessage.OTAEvent (reboot_ota_mode, ota_hash) and updates the rebootOTA docstring to clarify firmware version applicability.
meshtastic/main.py Imports meshtastic.ota/admin_pb2, adds the --ota-update admin CLI flag, and invokes startOTA() plus the ESP32WiFiOTA flow when running over a TCP interface.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread meshtastic/__main__.py
Comment thread meshtastic/node.py
Comment thread meshtastic/__main__.py Outdated
Comment thread meshtastic/__main__.py Outdated

skgsergio commented Jan 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I'll resolve copilot comments as soon as I'm back to my laptop as well as CI issues.

thebentern and others added 2 commits January 31, 2026 18:15
Update meshtastic/__main__.py
bf580c3 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fix: throw propper exceptions and cleanup code
4d8430d

skgsergio commented Feb 1, 2026

Copy link
Copy Markdown
Contributor Author

That should be it.

codecov Bot commented Feb 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.21429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.83%. Comparing base (cdf893e) to head (5721859).
⚠️ Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/__main__.py 91.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #898      +/-   ##
==========================================
+ Coverage   59.82%   60.83%   +1.00%     
==========================================
  Files          24       25       +1     
  Lines        4329     4440     +111     
==========================================
+ Hits         2590     2701     +111     
  Misses       1739     1739
Flag Coverage Δ
unittests 60.83% <98.21%> (+1.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

skgsergio force-pushed the feat/esp32-unified-ota branch from 0d3cc6f to 4de19f5 Compare February 1, 2026 20:25
skgsergio mentioned this pull request Feb 12, 2026
Merged

Nevermore-42 commented Feb 13, 2026

Copy link
Copy Markdown

Tested this on G2 and it works as expected

fgimenezm commented Feb 13, 2026

Copy link
Copy Markdown

Worked Ok on a Heltec V3

skgsergio commented Feb 14, 2026

Copy link
Copy Markdown
Contributor Author

Fixed the CI errors

ianmcorvidae commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

I think this seems good and I'll get it merged. Noting here but doesn't need to be your work if you don't want to, but we might add an optional argument to --reboot-ota that lets users manually reboot into an appropriate mode, to enable the BLE side of things without needing to actually implement the BLE uploading etc. But I haven't dug that hard into how it all works, either, so I'm not sure the best UI there.

ianmcorvidae merged commit 1e4822f into meshtastic:master Mar 2, 2026
9 checks passed
skgsergio deleted the feat/esp32-unified-ota branch March 5, 2026 13:03
MayNiklas mentioned this pull request Mar 12, 2026
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
ianmcorvidae Awaiting requested review from ianmcorvidae

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL