Fix up the container build - #932
Merged
ianmcorvidae merged 1 commit intoJun 8, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…and most importantly actually keep the library in the final image (fixes meshtastic#931)
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #932 +/- ##
=======================================
Coverage 63.19% 63.19%
=======================================
Files 25 25
Lines 4521 4521
=======================================
Hits 2857 2857
Misses 1664 1664
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
jeremiah-k
added a commit
to jeremiah-k/mtjk
that referenced
this pull request
Jun 11, 2026
Reconcile upstream/master (through 2.7.9) with develop after squash-merge of docker-updates-2.7.9. All conflicts resolved with --ours: content was already adapted for mtjk fork. Upstream commits incorporated: - dd1df47 Fix up container build (multi-stage, caching, keep library) - e216848 Merge PR meshtastic#932 (container fixup) - 6eeb900 bump version to 2.7.9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...to use a multi-stage build, cache better, and most importantly actually keep the library in the final image (fixes #931)
The issue with not keeping the library around was almost certainly my own fault when amending the prior PR for some other changes. My bad there!