Add support for adding contacts using the CLI, including remotely - #933
Add support for adding contacts using the CLI, including remotely#933ianmcorvidae merged 6 commits into
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Pull request overview
This PR adds a CLI workflow for sharing and importing “contact” (node/user) information via a shareable URL/QR, enabling users to add contacts to the NodeDB locally or via remote admin actions.
Changes:
- Add Node.getContactURL() and Node.addContactURL() for generating/parsing shareable contact URLs backed by admin_pb2.SharedContact.
- Extend the CLI with --contact-qr (generate + print QR/URL) and --add-contact (import from URL), supporting remote destinations via --dest.
- Add unit tests covering CLI argument plumbing and a protobuf URL encode/decode roundtrip.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| meshtastic/node.py | Implements contact URL generation/parsing and sends AdminMessage.add_contact. |
| meshtastic/__main__.py | Adds CLI flags and wiring to call the new Node APIs (local or remote). |
| meshtastic/tests/test_node.py | Adds a protobuf-level contact URL encode/decode roundtrip test. |
| meshtastic/tests/test_main.py | Adds CLI tests for --add-contact and --contact-qr argument handling. |
Sorry, something went wrong.
Codecov Report❌ Patch coverage is 94.20290% with 4 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## master #933 +/- ##
==========================================
+ Coverage 63.24% 63.72% +0.47%
==========================================
Files 25 25
Lines 4527 4595 +68
==========================================
+ Hits 2863 2928 +65
- Misses 1664 1667 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
No description provided.