Update Dockerfile - #101
Merged
pablogs9 merged 2 commits intoSep 14, 2023
Merged
pablogs9 merged 2 commits into
pablogs9 merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Change entry script call
pablogs9
requested changes
Sep 13, 2023
Comment thread
micro-ROS-static-library-builder/Dockerfile
Outdated
Remove redundant code
ncnynl
commented
Sep 13, 2023
ncnynl
left a comment
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Remove redundant code
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Could you explain the rationale of this PR a bit? |
Sorry, something went wrong.
ncnynl
commented
Sep 14, 2023
ncnynl
left a comment
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
ENTRYPOINT ["/entrypoint.sh"] it will have permission issues, causing it to not work properly when running docker container. so change into ENTRYPOINT ["/bin/sh", "/entrypoint.sh"] can fixed it
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
✅ Backports have been createdDetails
|
Sorry, something went wrong.
mergify Bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
* Update Dockerfile Change entry script call * Update Dockerfile Remove redundant code (cherry picked from commit f8ebbaf)
mergify Bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
* Update Dockerfile Change entry script call * Update Dockerfile Remove redundant code (cherry picked from commit f8ebbaf)
pablogs9
pushed a commit
that referenced
this pull request
Sep 14, 2023
pablogs9
pushed a commit
that referenced
this pull request
Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change entry script call