FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add stop functionality by Acuadros95 · Pull Request #89 · micro-ROS/micro-ROS-Agent · GitHub

/ micro-ROS-Agent Public

Add stop functionality - #89

Open
Acuadros95 wants to merge 22 commits into
rollingfrom
feature/stop_agent
ConversationCommits (22)ChecksFiles changed
Open

Add stop functionality#89
Acuadros95 wants to merge 22 commits into
rollingfrom
feature/stop_agent

Conversation

Acuadros95 commented Jul 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Todo: modify cmake to build as library

mergify Bot and others added 6 commits July 2, 2021 09:48
Fix graph manager node namespaces (#72) (#74)
a313a08 
(cherry picked from commit a623308)

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
Fix graph manager node namespaces (#75) (#77)
ee955ed 
* Fix graph manager node namespaces

* Update

(cherry picked from commit f6a2aa3)

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
Fix agent launch (#78) (#80)
a8caaa1 
Co-authored-by: Your Name <you@example.com>
(cherry picked from commit 69f17c2)

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
Graph manager: Fix participant mask for listener callbacks (#81) (#82)
e43cde1 
(cherry picked from commit 95fecd7)

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
Fix graph manager datawriters behaviour (#84) (#85)
256424b 
* Fix graph manager datawriters

Fixes

Fix

Fix destruction

* Revert "Fix graph manager datawriters"

This reverts commit 2847a2e.

* Initial

(cherry picked from commit 646ca52)

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
Add stop functionality
ff3b6f3
Acuadros95 requested a review from pablogs9 July 21, 2021 11:49

Acuadros95 commented Jul 27, 2021

Copy link
Copy Markdown
Contributor Author

@mergify backport galactic foxy

mergify Bot commented Jul 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

backport galactic foxy

🟠 Waiting for conditions to match

Details
  • merged [📌 backport requirement]

pablogs9 commented Jul 27, 2021

Copy link
Copy Markdown
Member

This PR should target main branch and be backported to galactic and foxy

Acuadros95 changed the base branch from galactic to main July 27, 2021 13:33
pablogs9 reviewed Jul 28, 2021
View reviewed changes
Comment thread micro_ros_agent/include/agent/graph_manager/graph_manager.hpp
if (microros_graph_publisher_.joinable())
{
exit = true;
cv_.notify_one();

pablogs9 Jul 28, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Indent

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogs9 pablogs9 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL