FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixed launch file by using a list for arguments. by mecarill · Pull Request #93 · micro-ROS/micro-ROS-Agent · GitHub

  1. micro-ROS
  2. micro-ROS-Agent

Repository navigation

Fixed launch file by using a list for arguments. - #93

Merged
pablogs9 merged 1 commit into
micro-ROS:foxyfrom
mecarill:fix_launch
Aug 25, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Fixed launch file by using a list for arguments. #93
pablogs9 merged 1 commit into
micro-ROS:foxyfrom
mecarill:fix_launch

Conversation

mecarill commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

Arguments were being fed in a random order. Using a list ensures that it is consistently being fed in order.

pablogs9 commented Aug 25, 2021

Copy link
Copy Markdown
Member

@mergify backport main galactic

pablogs9 commented Aug 25, 2021

Copy link
Copy Markdown
Member

@mecarill thanks a lot for the contribution, good catch

mergify Bot commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

Command backport main galactic: pending

Waiting for the pull request to get merged

Hey, I reacted but my real name is @Mergifyio

pablogs9 merged commit fe1b3ad into micro-ROS:foxy Aug 25, 2021
mergify Bot pushed a commit that referenced this pull request Aug 25, 2021
Fixed launch file by using a list for arguments. Ensures order of ite…
9e699ba 
…ms is kept. (#93)

Co-authored-by: mecarill <mihkailkennerley@gmail.com>
(cherry picked from commit fe1b3ad)
mergify Bot mentioned this pull request Aug 25, 2021
Merged
mergify Bot pushed a commit that referenced this pull request Aug 25, 2021
Fixed launch file by using a list for arguments. Ensures order of ite…
81ba2ce 
…ms is kept. (#93)

Co-authored-by: mecarill <mihkailkennerley@gmail.com>
(cherry picked from commit fe1b3ad)
mergify Bot mentioned this pull request Aug 25, 2021
Merged

mergify Bot commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

Command backport main galactic: success

Backports have been created

pablogs9 pushed a commit that referenced this pull request Aug 25, 2021
Fixed launch file by using a list for arguments. Ensures order of ite…
c987053 
…ms is kept. (#93) (#94)

Co-authored-by: mecarill <mihkailkennerley@gmail.com>
(cherry picked from commit fe1b3ad)

Co-authored-by: mecarill <62688286+mecarill@users.noreply.github.com>
pablogs9 pushed a commit that referenced this pull request Aug 25, 2021
Fixed launch file by using a list for arguments. Ensures order of ite…
7369137 
…ms is kept. (#93) (#95)

Co-authored-by: mecarill <mihkailkennerley@gmail.com>
(cherry picked from commit fe1b3ad)

Co-authored-by: mecarill <62688286+mecarill@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogs9 pablogs9 approved these changes
+1 more reviewer
Acuadros95 Acuadros95 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL