Fix atomic 64bits - #171
Merged
pablogs9 merged 4 commits intoSep 17, 2020
Merged
pablogs9 merged 4 commits into
pablogs9 merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
pablogs9
force-pushed
the
feature/fix_atomic_64bits
branch
from
3446fc0 to
3f3cc7e
Compare
August 6, 2020 11:31
pablogs9
force-pushed
the
feature/fix_atomic_64bits
branch
2 times, most recently
from
8a494d8 to
0cfaca8
Compare
September 17, 2020 07:37
pablogs9
marked this pull request as ready for review
September 17, 2020 11:15
To be reverted when merged
This reverts commit 877e874.
pablogs9
force-pushed
the
feature/fix_atomic_64bits
branch
from
bf38936 to
5f8c5f5
Compare
September 17, 2020 13:28
jamoralp
approved these changes
Sep 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tests the rcutils branch in order to manage 64 bits atomics in 32 bits architectures.
The approach is to use true 32 bits atomics when 64 bits operations are required.
The usage of the libatomic.c file is removed from all micro-ROS auxiliary repos and the further implementation of 64 bits atomics will be implemented in rcutils.
Before merge: