Added movetoGPS - #3746
Merged
David Zimmermann (zimmy87) merged 6 commits intoDec 2, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Would it make sense to also support a function similar to moveOnPath? |
Sorry, something went wrong.
David Zimmermann (zimmy87)
marked this pull request as ready for review
December 2, 2021 08:43
removing extra white space accidentally added during merge
Copy link
Copy Markdown
Contributor
|
Thanks for the contribution Ahmed Elsaharti (@ahmed-elsaharti)! Tested this locally and it works as expected for me, so I am moving ahead with merging. As for Florian Spieß (@MinnDevelopment)'s comment, a GPS-enabled version of moveOnPath would be great, but I think it's a little out of scope for this PR (it'd be a great idea for a separate PR). |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
Adds a movetoGPS API to let users specify a GPS position to go to rather than being limited to NED space with movement APIs when using simpleflight.
Almost an exact copy of the movetoposition call but uses the home-geopoint to calculate the NED coordinates of the GPS position provided and passes that to the move method (in NED).
Still a WIP but would love to hear any feedback
How Has This Been Tested?
Tested locally on Windows