FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Dynamically set object textures from existing UE material or texture PNG by saihv · Pull Request #3992 · microsoft/AirSim · GitHub

/ AirSim Public

Dynamically set object textures from existing UE material or texture PNG - #3992

Merged
David Zimmermann (zimmy87) merged 7 commits into
microsoft:masterfrom
saihv:PR/ChangeMaterial
Nov 9, 2021
ConversationCommits (7)ChecksFiles changed
Merged

Dynamically set object textures from existing UE material or texture PNG#3992
David Zimmermann (zimmy87) merged 7 commits into
microsoft:masterfrom
saihv:PR/ChangeMaterial

Conversation

Sai Vemprala (saihv) commented Aug 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

About

This PR adds API functions to dynamically change the textures of in-game objects either to existing Unreal material assets (simSetObjectMaterial), or to arbitrary texture PNGs (simSetObjectMaterialFromTexture) - in order to help with generating data with domain randomization. Path to a .uasset or an image file (.png, .jpg etc.) should be specified based on the function being used.

How Has This Been Tested?

Run AirSim with the Blocks map, and run PythonClient/environment/change_texture_example.py

Screenshots (if appropriate):

Rajat Singhal (rajat2004) reviewed Aug 28, 2021
View reviewed changes

Rajat Singhal (rajat2004) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Really love the texture in the example!

Comment thread AirLib/include/api/RpcLibClientBase.hpp Outdated
Comment thread Unreal/Plugins/AirSim/Source/WorldSimApi.cpp Outdated
Comment thread Unreal/Plugins/AirSim/Source/WorldSimApi.cpp Outdated
Comment thread Unreal/Plugins/AirSim/Source/WorldSimApi.cpp Outdated
Comment thread Unreal/Plugins/AirSim/Source/WorldSimApi.cpp Outdated
Comment thread Unreal/Plugins/AirSim/Source/WorldSimApi.cpp Outdated
Comment thread Unreal/Plugins/AirSim/Source/WorldSimApi.cpp Outdated
Comment thread Unreal/Plugins/AirSim/Source/WorldSimApi.cpp Outdated
Comment thread Unreal/Plugins/AirSim/Source/WorldSimApi.cpp Outdated
Comment thread Unreal/Plugins/AirSim/Source/WorldSimApi.cpp Outdated

Sai Vemprala (saihv) commented Aug 28, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for the review, Rajat Singhal (@rajat2004) - I've pushed some fixes!

David Zimmermann (zimmy87) suggested changes Nov 4, 2021
View reviewed changes

David Zimmermann (zimmy87) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi Sai Vemprala (@saihv), thanks for submitting this PR, this looks like a good change to take, however I'm having trouble launching the Blocks environment with your PR checked out. I get the following error message:

---------------------------
Message
---------------------------
Default Property warnings and errors:
Error: CDO Constructor (SimModeBase): Failed to find Material'/AirSim/HUDAssets/DomainRandomizationMaterial.DomainRandomizationMaterial'


---------------------------
OK   
---------------------------

I checked and confirmed that Unreal/Plugins/AirSim/Content/HUDAssets/DomainRandomizationMaterial.uasset is present in my repo and Blocks environment, but it doesn't show up in the editor. Just out of curiosity, which version of the editor are you using? There may be a version mismatch here.

Update DomainRandomizationMaterial.uasset
fb49b66 
recreate DomainRandomizationMaterial to make it compatible with UE 4.25
add method stubs
f853b88 
add new method stubs for setObjectMaterial APIs
fix clang-format
f0ffcc5

David Zimmermann (zimmy87) commented Nov 9, 2021

Copy link
Copy Markdown
Contributor

I was able to test this locally and confirmed the new APIs are working as expected. Thanks for submitting this PR Sai Vemprala (@saihv)!

David Zimmermann (zimmy87) merged commit 1ba33b7 into microsoft:master Nov 9, 2021
David Zimmermann (zimmy87) mentioned this pull request Nov 16, 2021
Merged
최해선 (HSC-1) mentioned this pull request Mar 9, 2022
Closed
최해선 (HSC-1) mentioned this pull request Apr 7, 2022
Merged
David Zimmermann (zimmy87) mentioned this pull request Apr 25, 2022
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
Rajat Singhal (rajat2004) rajat2004 left review comments
David Zimmermann (zimmy87) zimmy87 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api feature request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL