Add support for aarch64 - #240
Open
Alex Mihaiuc (foxmsft) wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
I did not test the non-BTF part, a BTF-only kernel is probably common enough. |
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
Adds aarch64 build, syscall, and packaging support.
Changes:
- Adds architecture-aware CMake and cross-compilation configuration.
- Handles syscalls unavailable on aarch64.
- Produces architecture-specific DEB/RPM packages and documentation.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file| File | Description |
|---|---|
| sysmonforlinux.c | Guards architecture-specific syscalls. |
| package/DEBIAN.in/control.in | Adds dynamic package architecture. |
| makePackages.sh | Supports DEB/RPM architecture arguments. |
| linuxVersion.h.in | Updates copyright year. |
| linuxTypes.h | Avoids CO-RE type conflicts. |
| ebpfKern/sysmonProcCreate.c | Removes conflicting header. |
| ebpfKern/sysmonFileOpen.c | Handles missing open syscall. |
| ebpfKern/sysmonFileOpen_rawtp.c | Restricts available open syscalls. |
| ebpfKern/sysmonFileDelete_rawtp.c | Guards missing unlink. |
| ebpfKern/sysmonFileCreate_rawtp.c | Guards missing creat. |
| ebpfKern/sysmonEBPF_common.h | Uses architecture-neutral syscall header. |
| CMakeLists.txt | Adds architecture-aware builds and dependencies. |
| cmake/aarch64-linux-gnu.cmake | Defines the aarch64 toolchain. |
| BUILD.md | Documents aarch64 cross-building. |
| .container/install-ubuntu-dependencies.sh | Removes x86-only dependency. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Comment thread
CMakeLists.txt
| BUILD_COMMAND cd ../openssl && make && rm -rf ${PROJECT_BINARY_DIR}/openssl/src/openssl/cloudflare-quiche && rm -rf ${PROJECT_BINARY_DIR}/openssl/src/openssl/pyca-cryptography | ||
| BUILD_IN_SOURCE TRUE | ||
| CONFIGURE_COMMAND ${OPENSSL_CONFIGURE_COMMAND} | ||
| BUILD_COMMAND "${CMAKE_MAKE_PROGRAM}" |
Comment thread
BUILD.md
Comment on lines
+83
to
+85
| First cross-build and stage SysinternalsEBPF as described in its `BUILD.md`. | ||
| The commands below assume its staged installation is in | ||
| `../SysinternalsEBPF/build-arm64/staging`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the aarch64 platform for ARM64 processors.