Fix Copilot plugin registration on Windows - #2947
Open
George Ng (GeorgeNgMsft) wants to merge 4 commits into
Open
Fix Copilot plugin registration on Windows#2947George Ng (GeorgeNgMsft) wants to merge 4 commits into
George Ng (GeorgeNgMsft) wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Stage the bundled plugin runtime instead of copying pnpm workspace junctions, make snapshot replacement reliable on Windows, and verify registration before reporting success. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f02024b3-ee8f-4384-bcfc-7c774768d6f7
Address adversarial review findings for Windows command shims, custom Copilot homes, exact plugin matching, reported CLI failures, and MSI error propagation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f02024b3-ee8f-4384-bcfc-7c774768d6f7
Centralize migration, invocation, update fallback, and verification in the shared registrar. Keep Windows snapshot deletion scoped to the observed access-denied failure and preserve existing MSI failure semantics. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f02024b3-ee8f-4384-bcfc-7c774768d6f7
George Ng (GeorgeNgMsft)
enabled auto-merge
August 29, 2026 07:35
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f02024b3-ee8f-4384-bcfc-7c774768d6f7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes pnpm run register on Windows by staging only the bundled TypeAgent plugin files instead of copying the workspace’s pnpm-linked node_modules. The command still registers the local marketplace and installs or updates the plugin, but now handles the Windows access-denied case and verifies the plugin was actually installed before reporting success.