Support find-all-references for a module specifier - #15737
Merged
2 commits merged intoMay 19, 2017
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
ghost
requested a review
from Ron Buckton (rbuckton)
May 11, 2017 21:20
Mohamed Hegazy (mhegazy)
approved these changes
May 18, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14780
The basic fix is relatively simple if not for /// <reference paths> directives.
There was previously no exposed way to find what file it pointed to. Added a method on Program to do that. tryResolveScriptReference was unreliable as it didn't handle extensions.
This also changes the range for a reference comment to be just the text of the module identifier.
We also now need to pass the Program to findAllReferences instead of just the checker.
Does not yet solve #15736.