Cast identifier names to string in lint rule - #17027
Merged
Wesley Wigham (weswigham) merged 1 commit intoJul 7, 2017
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
To be compatible with both the current version of the compiler and the nightly (which uses a branded string for the text member).
Deleted user (ghost)
approved these changes
Jul 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be compatible with both the current version of the compiler and the nightly (which uses a branded string for the text member).
The lint doesn't care about leading underscores in the strings its searching, so it doesn't need to escape anything anyway.
Fixes #17020.