FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

processDiagnosticMessages: Simplify code and emit · Pull Request #17463 · microsoft/TypeScript · GitHub

/ TypeScript Public

processDiagnosticMessages: Simplify code and emit - #17463

Merged
1 commit merged into
masterfrom
diagnosticMessages
Jul 28, 2017
ConversationCommits (1)ChecksFiles changed
Merged

processDiagnosticMessages: Simplify code and emit#17463
1 commit merged into
masterfrom
diagnosticMessages

Conversation

Deleted user (ghost) commented Jul 27, 2017

Copy link
Copy Markdown

Currently the type of DiagnosticMessages is:

const ts.Diagnostics: {
	Unterminated_string_literal: {
	    code: number;
	    category: DiagnosticCategory;
	    key: string;
	    message: string;
	};
	Identifier_expected: {
		code: number;
		...

This changes it to:

const ts.Diagnostics: {
	Unterminated_string_literal: DiagnosticMessage;
	Identifier_expected: DiagnosticMessage;
	...
}

by changing the emit to use a diag helper function instead of having a unique object literal per diagnostic.

ghost requested a review from Wesley Wigham (weswigham) July 27, 2017 20:58
ghost force-pushed the diagnosticMessages branch from 877b76c to f7dacd8 Compare July 27, 2017 21:06
ghost force-pushed the diagnosticMessages branch from f7dacd8 to f1ef000 Compare July 27, 2017 21:30
ghost merged commit b81e71d into master Jul 28, 2017
ghost deleted the diagnosticMessages branch July 28, 2017 17:12

Mine Starks (minestarks) commented Jul 31, 2017

Copy link
Copy Markdown
Contributor

Andy (Andrewkraft) (@Andy-MS) I think this (or a related change) broke diagnosticsMessages.generated.json generation... Please see

https://devdiv.visualstudio.com/DevDiv/_git/TypeScript?path=%2FVS%2Fpublic_store%2Fret%2FdiagnosticMessages.generated.json&version=GBmaster-dev15&_a=contents&line=1&lineStyle=plain&lineEnd=2&lineStartColumn=1&lineEndColumn=1

Mine Starks (minestarks) commented Jul 31, 2017

Copy link
Copy Markdown
Contributor

Wesley Wigham (@weswigham) ?

Wesley Wigham (weswigham) mentioned this pull request Jul 31, 2017
Merged
Microsoft (microsoft) locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL