FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Generate diagnostics without a leading comma, retain old spaces by weswigham · Pull Request #17534 · microsoft/TypeScript · GitHub

/ TypeScript Public

Generate diagnostics without a leading comma, retain old spaces #17534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wesley Wigham (weswigham) merged 2 commits into from
Jul 31, 2017
Conversation 2 Commits 2 Checks 0 Files changed
Merged

Generate diagnostics without a leading comma, retain old spaces #17534

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca93e33
Generate diagnostics without a leading comma, reatain space
weswigham Jul 31, 2017
ac84941
Add small assertion that we generate valid json
weswigham Jul 31, 2017
File filter

Filter by extension

Filter by extension .ts  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
16 changes: 6 additions & 10 deletions scripts/processDiagnosticMessages.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -76,20 +76,16 @@ function buildInfoFileOutput(messageTable: InputDiagnosticMessageTable): string

function buildDiagnosticMessageOutput(messageTable: InputDiagnosticMessageTable): string {
let result = '{';
let first = true;
messageTable.forEach(({ code }, name) => {
if (!first) {
first = false;
}
else {
result += ',';
}

const propName = convertPropertyName(name);
result += `\r\n "${createKey(propName, code)}": "${name.replace(/[\"]/g, '\\"')}"`;
result += `\r\n "${createKey(propName, code)}" : "${name.replace(/[\"]/g, '\\"')}",`;
});

result += '\r\n}';
// Shave trailing comma, then add newline and ending brace
result = result.slice(0, result.length - 1) + '\r\n}';

// Assert that we generated valid JSON
JSON.parse(result);

return result;
}
Expand Down
Back | FazBrowse Home | New Git URL