Convert two arrays to readonly - #17685
Merged
1 commit merged intoAug 8, 2017
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
ghost
requested a review
from Wesley Wigham (weswigham)
August 8, 2017 17:27
ghost
force-pushed
the
emptyArray_readonly
branch
from
5a936b2 to
0296eef
Compare
August 8, 2017 17:33
Wesley Wigham (weswigham)
approved these changes
Aug 8, 2017
ghost
deleted the
emptyArray_readonly
branch
August 8, 2017 17:54
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cast is currently causing errors when running gulp local on the master branch. Turns out it's pretty easy to fix just this without any big API changes.
return emptyArray as string[]; // TODO: https://github.com/Microsoft/TypeScript/issues/16312 ~~~~~~~~~~~~~~~~~~~~~~ src/server/server.ts(772,20): error TS2352: Type 'SortedReadonlyArray<never>' cannot be converted to type 'string[]'.