Fixes to emit / format for codeFix - #18484
Merged
1 commit merged intoSep 14, 2017
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
ghost
requested a review
from Ron Buckton (rbuckton)
September 14, 2017 21:16
Mohamed Hegazy (mhegazy)
approved these changes
Sep 14, 2017
Copy link
Copy Markdown
Contributor
|
let's port it to release-2.5 as well. |
Sorry, something went wrong.
ghost
deleted the
text_changes_fixes
branch
September 14, 2017 21:30
This was referenced Sep 14, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18437
Fixes #18434
This is basically a sequel to #18284 -- we need to remember to call callbacks for an empty list (e.g. from an empty case statement). We also can't look assume that parent exists in formatting rules, because synthesized nodes don't have parents.
Mohamed Hegazy (@mhegazy) This might be a good idea to get in for 2.5.3.