TypedArrays: fixed find and findIndex callback param obj type. - #18493
TypedArrays: fixed find and findIndex callback param obj type.#18493Mohamed Hegazy (mhegazy) merged 1 commit into
Conversation
Sorry, something went wrong.
|
Adrian Leonhard (@NaridaL), |
Sorry, something went wrong.
| * predicate. If it is not provided, undefined is used instead. | ||
| */ | ||
| find(predicate: (value: number, index: number, obj: Array<number>) => boolean, thisArg?: any): number | undefined; | ||
| find(predicate: (value: number, index: number, obj: Int16Array) => boolean, thisArg?: any): number | undefined; |
There was a problem hiding this comment.
Uint16Array ?
Sorry, something went wrong.
| * predicate. If it is not provided, undefined is used instead. | ||
| */ | ||
| findIndex(predicate: (value: number, index: number, obj: Array<number>) => boolean, thisArg?: any): number; | ||
| findIndex(predicate: (value: number, index: number, obj: Int16Array) => boolean, thisArg?: any): number; |
There was a problem hiding this comment.
Uint16Array
Sorry, something went wrong.
| * predicate. If it is not provided, undefined is used instead. | ||
| */ | ||
| find(predicate: (value: number, index: number, obj: Array<number>) => boolean, thisArg?: any): number | undefined; | ||
| find(predicate: (value: number, index: number, obj: Int32Array) => boolean, thisArg?: any): number | undefined; |
There was a problem hiding this comment.
Uint32Array
Sorry, something went wrong.
| * predicate. If it is not provided, undefined is used instead. | ||
| */ | ||
| findIndex(predicate: (value: number, index: number, obj: Array<number>) => boolean, thisArg?: any): number; | ||
| findIndex(predicate: (value: number, index: number, obj: Int32Array) => boolean, thisArg?: any): number; |
There was a problem hiding this comment.
Uint32Array
Sorry, something went wrong.
|
Yeah... sorry about that. BTW, I tried it with the separate TypedArray interface, and it seems to be an improvement... previous: PS C:\Users\aval\tsdev\TypeScript> node built\local\tsc.js --diagnostics --p src\compiler\tsconfig.json Files: 36 Lines: 93186 Nodes: 445312 Identifiers: 168285 Symbols: 71668 Types: 32088 Memory used: 371617K I/O read: 0.02s I/O write: 0.17s Parse time: 0.71s Bind time: 0.62s Check time: 2.90s Emit time: 2.06s Total time: 6.29s now: PS C:\Users\aval\tsdev\TypeScript> node built\local\tsc.js --diagnostics --p src\compiler\tsconfig.json Files: 36 Lines: 91325 Nodes: 440475 Identifiers: 166994 Symbols: 70992 Types: 31941 Memory used: 350637K I/O read: 0.03s I/O write: 0.03s Parse time: 0.69s Bind time: 0.58s Check time: 2.84s Emit time: 1.88s Total time: 5.98s ... not sure if those statistics are the only relevant thing though. |
Sorry, something went wrong.
|
Oh yeah, the issues with U/Intarray should be fixed now, because it's not immediately obvious from the code reviews^^. |
Sorry, something went wrong.
|
We should be moving them out of es5.d.ts anyways. #15780 should be in first though. |
Sorry, something went wrong.
Fixes #18425.