Fix checking of recursive callback types - #19107
Merged
Anders Hejlsberg (ahejlsberg) merged 3 commits intoOct 11, 2017
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Anders Hejlsberg (ahejlsberg)
requested review from
Mohamed Hegazy (mhegazy) and
Nathan Shively-Sanders (sandersn)
October 11, 2017 19:11
Nathan Shively-Sanders (sandersn)
approved these changes
Oct 11, 2017
Mohamed Hegazy (mhegazy)
approved these changes
Oct 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the logic introduced in #15104 to only check for callback parameters when we aren't in a recursive call to compareSignaturesRelated that resulted from an outer callback check.
Fixes #18277.