Import fix add import require support - #19802
Merged
Mohamed Hegazy (mhegazy) merged 3 commits intoNov 7, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Aluan Haddad (aluanhaddad)
force-pushed
the
import-fix-add-import-require-support
branch
from
ec865b7 to
853937e
Compare
November 7, 2017 16:57
Aluan Haddad (aluanhaddad)
force-pushed
the
import-fix-add-import-require-support
branch
from
853937e to
555b4ae
Compare
November 7, 2017 17:09
Copy link
Copy Markdown
Contributor
|
thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
In this follow-up to #19572 code fixes that import a UMD module now prefer the import..require syntax when --module is commonjs, amd, or umd and synthetic defaults are not available.