generateGetAccessorAndSetAccessor: Share modifier-creating code - #23311
Merged
2 commits merged intoApr 12, 2018
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
ghost
requested review from
Andrew Casey (amcasey) and
Mohamed Hegazy (mhegazy)
April 10, 2018 19:13
Mohamed Hegazy (mhegazy)
approved these changes
Apr 11, 2018
Andrew Casey (amcasey)
approved these changes
Apr 12, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had some code review on #22143 but didn't want to delay it any longer. Wenlu Wang (@Kingwl)