generateGetAccessorAndSetAccessor: Preserve a parameter property declaration - #23318
Merged
3 commits merged intoMay 7, 2018
Merged
generateGetAccessorAndSetAccessor: Preserve a parameter property declaration#233183 commits merged into
3 commits merged into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
ghost
requested review from
Andrew Casey (amcasey) and
Mohamed Hegazy (mhegazy)
April 10, 2018 21:28
Mohamed Hegazy (mhegazy)
approved these changes
Apr 13, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had some code review on #22143 but didn't want to delay it any longer. Wenlu Wang (@Kingwl)
Previously the parameter would be deleted and a property inserted elsewhere. That would be a breaking change as constructor callers will still expect to be able to pass in the parameter. Instead, we can leave the parameter property in place and change it to private if necessary.