Fix source map decoding to handle case sensitivity and --out option - #28273
Merged
Sheetal Nandi (sheetalkamat) merged 2 commits intoNov 1, 2018
Merged
Fix source map decoding to handle case sensitivity and --out option#28273Sheetal Nandi (sheetalkamat) merged 2 commits into
Sheetal Nandi (sheetalkamat) merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Sheetal Nandi (sheetalkamat)
requested review from
a user,
Ron Buckton (rbuckton),
Nathan Shively-Sanders (sandersn) and
Wesley Wigham (weswigham)
October 31, 2018 22:43
Deleted user (ghost)
approved these changes
Oct 31, 2018
Wesley Wigham (weswigham)
approved these changes
Oct 31, 2018
mihailik
reviewed
Nov 6, 2018
Comment thread
src/compiler/sourcemapDecoder.ts
| targetIndex = ~targetIndex; | ||
| } | ||
| if (!maps[targetIndex] || comparePaths(loc.fileName, maps[targetIndex].sourcePath, sourceRoot) !== 0) { | ||
| if (!maps[targetIndex] || comparePaths(loc.fileName, maps[targetIndex].sourcePath, sourceRoot, !host.useCaseSensitiveFileNames) !== 0) { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Should that ignoreCase parameter in comparePaths be mandatory?
It doesn't look like is EVER safe to assume 'ignore case' without consulting the actual host parameter.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while working on #28261