FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

馃 User test baselines have changed by typescript-bot 路 Pull Request #32267 路 microsoft/TypeScript 路 GitHub

馃 User test baselines have changed - #32267

Closed
TypeScript Bot (typescript-bot) wants to merge 1 commit into
microsoft:masterfrom
typescript-bot:user-update-Microsoft-20190605
Closed

馃 User test baselines have changed#32267
TypeScript Bot (typescript-bot) wants to merge 1 commit into
microsoft:masterfrom
typescript-bot:user-update-Microsoft-20190605

Conversation

Copy link
Copy Markdown
Contributor

Please review the diff and merge if no changes are unexpected.
You can view the build log here.

cc Wesley Wigham (@weswigham) Nathan Shively-Sanders (@sandersn) Ryan Cavanaugh (@RyanCavanaugh)

Copy link
Copy Markdown
Member

cc Ron Buckton (@rbuckton) you look over these changes form the generator types PR yet?

Copy link
Copy Markdown
Contributor

I reviewed them following an on-demand run, but I'm not certain how to proceed. Do I accept these changes as is, or do I need to submit issues against the user test repositories for errors? The majority of changes are due to outdated NodeJS definitions.

Copy link
Copy Markdown
Member

It's up to us - if updating these projects for their maintainers is too cumbersome, we can accept the baseline (which just means merging this PR), but that does lower how clean the baselines are and how easy it is to identify future change. Plus, at least for the rush-build projects the error blocks the build, which really hurts the test value :P

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL