Better typings for Promise.then(), like #31117 - #33103
Closed
Jack Bates (jablko) wants to merge 2 commits into
Closed
Better typings for Promise.then(), like #31117#33103Jack Bates (jablko) wants to merge 2 commits into
Jack Bates (jablko) wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Jack Bates (jablko)
force-pushed
the
patch-6
branch
2 times, most recently
from
fb7d414 to
9855ca6
Compare
August 30, 2019 16:52
Jack Bates (jablko)
force-pushed
the
patch-6
branch
3 times, most recently
from
807672f to
dbd8fef
Compare
September 25, 2019 23:57
Jack Bates (jablko)
force-pushed
the
patch-6
branch
from
dbd8fef to
300d7da
Compare
October 1, 2019 16:10
Jack Bates (jablko)
force-pushed
the
patch-6
branch
4 times, most recently
from
57c746f to
0e5392b
Compare
October 7, 2019 14:31
Jack Bates (jablko)
force-pushed
the
patch-6
branch
2 times, most recently
from
1abb98b to
2409b6e
Compare
October 16, 2019 14:46
Jack Bates (jablko)
force-pushed
the
patch-6
branch
2 times, most recently
from
a720dc6 to
a7ba115
Compare
October 19, 2019 18:33
Jack Bates (jablko)
force-pushed
the
patch-6
branch
from
a7ba115 to
d63c14d
Compare
October 27, 2019 19:15
Jack Bates (jablko)
force-pushed
the
patch-6
branch
from
d63c14d to
e513e50
Compare
November 4, 2019 15:21
Jack Bates (jablko)
force-pushed
the
patch-6
branch
2 times, most recently
from
123fb1b to
5b1a139
Compare
November 16, 2019 15:24
Jack Bates (jablko)
force-pushed
the
patch-6
branch
5 times, most recently
from
26402ab to
ada7592
Compare
November 28, 2019 14:51
Jack Bates (jablko)
force-pushed
the
patch-6
branch
from
ada7592 to
d18ccf2
Compare
November 29, 2019 22:25
Jack Bates (jablko)
force-pushed
the
patch-6
branch
from
d18ccf2 to
8b59d90
Compare
December 28, 2019 17:09
Jack Bates (jablko)
force-pushed
the
patch-6
branch
3 times, most recently
from
babef3b to
09cad11
Compare
January 25, 2020 20:24
Jack Bates (jablko)
force-pushed
the
patch-6
branch
from
09cad11 to
f2bbeda
Compare
January 29, 2020 01:05
Jack Bates (jablko)
force-pushed
the
patch-6
branch
4 times, most recently
from
2f142db to
e28f834
Compare
February 9, 2020 17:19
Jack Bates (jablko)
force-pushed
the
patch-6
branch
5 times, most recently
from
e31427a to
d2c03e0
Compare
February 13, 2020 15:42
Jack Bates (jablko)
force-pushed
the
patch-6
branch
from
d2c03e0 to
f094abc
Compare
February 21, 2020 00:06
Jack Bates (jablko)
force-pushed
the
patch-6
branch
from
f094abc to
16b4a93
Compare
February 22, 2020 22:41
Copy link
Copy Markdown
Contributor
|
I'm concerned that these types would conflict with userland promise definitions. Also, the linked issue was closed by #45350, so I am closing this. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30390