Fix assert with declaration emit for export specifier for a global - #3641
Merged
Mohamed Hegazy (mhegazy) merged 1 commit intoJun 30, 2015
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This fixes the assertion error that I have seen. I'm getting a bunch of new errors on Angular, but I think those are because of the more precise type checking, now that our Promise doesn't end up being effectively any anymore. So cannot confirm 100% success yet, but this looks good. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
👍 |
Sorry, something went wrong.
Mohamed Hegazy (mhegazy)
added a commit
that referenced
this pull request
Jun 30, 2015
Fix assert with declaration emit for export specifier for a global
Wesley Wigham (weswigham)
added a commit
to weswigham/TypeScript
that referenced
this pull request
Nov 8, 2017
Wesley Wigham (weswigham)
added a commit
that referenced
this pull request
Nov 9, 2017
* Badness * Revert #3641, whose original bug has been fixed by other means * Add another repro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3640