| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
I've moved the logic out of checker and into services in a getAdjustedLocation function that handles both references and renames (i.e., renames have fewer adjusted locations for cases when there isn't a valid element to rename). |
Sorry, something went wrong.
|
Sheetal Nandi (@sheetalkamat) do you have any further feedback? |
Sorry, something went wrong.
This seems needlessly inconsistent. I don’t like this as it means if I delete X from the second import, the behavior of Find References suddenly changes. Either both cases should find refs for module or else the second case should just be an error. |
Sorry, something went wrong.
|
Bruce Pascoe (@fatcerberus) that's an interesting point. Daniel Rosenwasser (@DanielRosenwasser) do you have any preference here? |
Sorry, something went wrong.
|
I think it's often nice to have something just do the only possible successful action. We can change this later if people do find it confusing. |
Sorry, something went wrong.
|
I'll create a PR for this change shortly. |
Sorry, something went wrong.
|
I've put up a PR with the following changes:
|
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This change lets "find references" requests to the server find references to a declaration when the cursor is on certain keywords:
I've also updated runCode in our fourslash tests so that errors are reported at the source location in the test file (using source maps), and so that you can step through the ts file when debugging.
Fixes #13309
Fixes #28268