Faster exit from isTypeRelatedTo with identityRelation - #36590
Merged
Anders Hejlsberg (ahejlsberg) merged 2 commits intoFeb 6, 2020
Merged
Faster exit from isTypeRelatedTo with identityRelation#36590Anders Hejlsberg (ahejlsberg) merged 2 commits into
Anders Hejlsberg (ahejlsberg) merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
TypeScript Bot (@typescript-bot) run dt |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the perf test suite on this PR at c44f1a4. You can monitor the build here. It should now contribute to this PR's status checks. Update: The results are in! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at c44f1a4. You can monitor the build here. It should now contribute to this PR's status checks. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Anders Hejlsberg (@ahejlsberg) Comparison Report - master..36590
System
Hosts
Scenarios
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
TypeScript Bot (@typescript-bot) pack this |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Heya Andrew Casey (@amcasey), I've started to run the tarball bundle task on this PR at d6d9dd7. You can monitor the build here. It should now contribute to this PR's status checks. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Hey Andrew Casey (@amcasey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so: {
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/63158/artifacts?artifactName=tgz&fileId=A987F38F6364514260C7A68F64FA1F26CC816EB374A422F9891F2C151AB1791A02&fileName=/typescript-3.8.0-insiders.20200204.tgz"
}
}
and then running npm install. There is also a playground for this build. |
Sorry, something went wrong.
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Feb 4, 2020
Copy link
Copy Markdown
Member
|
10-run average from the original machine shows a 7% improvement. Very nice! |
Sorry, something went wrong.
Nathan Shively-Sanders (sandersn)
deleted the
optimizeIdentityRelation
branch
February 7, 2020 16:53
Copy link
Copy Markdown
Member
|
This change fixes a failure in checking in @types/mongoose of the form: interface E {
stack: string;
}
declare var y: E | undefined
declare var x: E;
var x = y; // error expected here, but none given
x.stackIt's very surprising to me that we didn't give an error here before. Note that we did give an error for number | undefined. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Maybe it's because we weren't strictly checking duplicate declaration sites before. Normal code like var x: E | undefined = y gives the error before this change. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces the total compile time of the test in #36564 by about 6%.
Fixes #36564.