FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Convert UnionOrIntersectionType.couldContainTypeVariables to ObjectFlags by amcasey · Pull Request #36947 · microsoft/TypeScript · GitHub

/ TypeScript Public

Convert UnionOrIntersectionType.couldContainTypeVariables to ObjectFlags - #36947

Merged
Andrew Casey (amcasey) merged 1 commit into
microsoft:masterfrom
amcasey:CouldContainFlag
Feb 25, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Convert UnionOrIntersectionType.couldContainTypeVariables to ObjectFlags#36947
Andrew Casey (amcasey) merged 1 commit into
microsoft:masterfrom
amcasey:CouldContainFlag

Conversation

Andrew Casey (amcasey) commented Feb 21, 2020

Copy link
Copy Markdown
Member

...to save space (and possibly to reduce de-opts, since it appears to be lazily set).

Convert UnionOrIntersectionType.couldContainTypeVariables to ObjectFlags
2e9972d 
...to save space (and possibly to reduce de-opts, since it appears to be
lazily set).

Andrew Casey (amcasey) commented Feb 21, 2020

Copy link
Copy Markdown
Member Author

Modelled on #36622.

Andrew Casey (amcasey) commented Feb 21, 2020

Copy link
Copy Markdown
Member Author

This seems unlikely to affect the perf tests, since it mostly applies to intersection and union types, which are not represented in the perf suite.

Andrew Casey (amcasey) commented Feb 21, 2020

Copy link
Copy Markdown
Member Author

Ugh, muscle memory...
TypeScript Bot (@typescript-bot) perf test

TypeScript Bot (typescript-bot) commented Feb 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Andrew Casey (@amcasey), I've started to run the perf test suite on this PR at 2e9972d. You can monitor the build here. It should now contribute to this PR's status checks.

Andrew Casey (amcasey) mentioned this pull request Feb 22, 2020
Merged
Wesley Wigham (weswigham) approved these changes Feb 25, 2020
View reviewed changes

Wesley Wigham (weswigham) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seems pretty straightforwardly good to me, and we can always shuffle around the object flags later if need be.

Andrew Casey (amcasey) merged commit b5bd38b into microsoft:master Feb 25, 2020
Andrew Casey (amcasey) deleted the CouldContainFlag branch February 25, 2020 02:18

Andrew Casey (amcasey) commented Feb 25, 2020

Copy link
Copy Markdown
Member Author

Wesley Wigham (@weswigham) Finders keepers 😉

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Wesley Wigham (weswigham) weswigham approved these changes
Anders Hejlsberg (ahejlsberg) Awaiting requested review from ahejlsberg
Ryan Cavanaugh (RyanCavanaugh) Awaiting requested review from RyanCavanaugh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL