FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(26217): Add missing member fix should work for missing function by a-tarasyuk · Pull Request #41215 · microsoft/TypeScript · GitHub

/ TypeScript Public

feat(26217): Add missing member fix should work for missing function - #41215

Merged
Jesse Trinity (jessetrinity) merged 6 commits into
microsoft:masterfrom
a-tarasyuk:feat/26217
Jan 9, 2021
ConversationCommits (6)ChecksFiles changed
Merged

feat(26217): Add missing member fix should work for missing function#41215
Jesse Trinity (jessetrinity) merged 6 commits into
microsoft:masterfrom
a-tarasyuk:feat/26217

Conversation

Oleksandr Tarasiuk (a-tarasyuk) commented Oct 23, 2020

Copy link
Copy Markdown
Contributor

Fixes #26217

TypeScript Bot (typescript-bot) added the For Backlog Bug PRs that fix a backlog bug label Oct 23, 2020
Oleksandr Tarasiuk (a-tarasyuk) marked this pull request as ready for review October 25, 2020 13:31
Closed

Daniel Rosenwasser (DanielRosenwasser) commented Dec 2, 2020

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) commented Dec 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the tarball bundle task on this PR at dc448f9. You can monitor the build here.

TypeScript Bot (typescript-bot) commented Dec 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hey Daniel Rosenwasser (@DanielRosenwasser), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/90205/artifacts?artifactName=tgz&fileId=C92047E7D012B4C56A628CDC8A2082B9C79E19DE6093DAD2FAFB6036C022EA4902&fileName=/typescript-4.2.0-insiders.20201202.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

Nathan Shively-Sanders (sandersn) approved these changes Dec 19, 2020
View reviewed changes

Nathan Shively-Sanders (sandersn) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just a couple of early comments -- I've looked at the tests, and they look good, but haven't looked at the code.

Comment thread tests/cases/fourslash/importNameCodeFixNewImportNodeModules5.ts Outdated
Comment thread src/services/codefixes/helpers.ts Outdated
Open
5 tasks
Jesse Trinity (jessetrinity) reviewed Jan 5, 2021
View reviewed changes

Jesse Trinity (jessetrinity) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I left a couple of questions but otherwise looks great 👍

Comment thread src/services/codefixes/fixAddMissingMember.ts
Comment thread src/services/codefixes/helpers.ts Outdated
Comment thread src/services/codefixes/helpers.ts Outdated
Jesse Trinity (jessetrinity) merged commit 0c58ede into microsoft:master Jan 9, 2021
Zzzen (Zzzen) pushed a commit to Zzzen/TypeScript that referenced this pull request Jan 16, 2021
feat(26217): Add missing member fix should work for missing function (m…
dfd7d97 
…icrosoft#41215)

* feat(26217): Add missing function declaration QF

* use codeFixAvailable instead of codeFix

* add diagnostics messages 'Method not implemented.' and 'Function not implemented.'

* use codeFixAvailable instead of codeFix

* fix signature types
Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Nathan Shively-Sanders (sandersn) sandersn approved these changes
Daniel Rosenwasser (DanielRosenwasser) Awaiting requested review from DanielRosenwasser
+1 more reviewer
Jesse Trinity (jessetrinity) jessetrinity approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

Nathan Shively-Sanders (sandersn)

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add missing member fix should work for missing function

5 participants

Back | FazBrowse Home | New Git URL