Allow override as parameter property - #43831
Merged
Andrew Branch (andrewbranch) merged 6 commits intoApr 28, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Andrew Branch (andrewbranch)
requested a review
from Daniel Rosenwasser (DanielRosenwasser)
April 26, 2021 17:58
Sheetal Nandi (sheetalkamat)
approved these changes
Apr 26, 2021
Comment thread
src/compiler/checker.ts
Daniel Rosenwasser (DanielRosenwasser)
requested changes
Apr 26, 2021
Daniel Rosenwasser (DanielRosenwasser)
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Please add the same sort of comment that's around the readonly modifier, then update checkGrammarModifiers
Sorry, something went wrong.
Sheetal Nandi (sheetalkamat)
approved these changes
Apr 27, 2021
Copy link
Copy Markdown
Contributor
|
Thanks! |
Sorry, something went wrong.
Andrew Branch (andrewbranch)
deleted the
feature/override-parameter-property
branch
April 28, 2021 23:41
This was referenced May 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#39669 (comment)