FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(28491): add QF to declare missing properties by a-tarasyuk · Pull Request #44576 · microsoft/TypeScript · GitHub

/ TypeScript Public

feat(28491): add QF to declare missing properties - #44576

Merged
Daniel Rosenwasser (DanielRosenwasser) merged 1 commit into
microsoft:mainfrom
a-tarasyuk:feat/28491
Jun 17, 2021
ConversationCommits (1)ChecksFiles changed
Merged

feat(28491): add QF to declare missing properties#44576
Daniel Rosenwasser (DanielRosenwasser) merged 1 commit into
microsoft:mainfrom
a-tarasyuk:feat/28491

Conversation

Oleksandr Tarasiuk (a-tarasyuk) commented Jun 14, 2021

Copy link
Copy Markdown
Contributor

Fixes #28491

TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 14, 2021
Oleksandr Tarasiuk (a-tarasyuk) marked this pull request as ready for review June 14, 2021 16:31

TypeScript Bot (typescript-bot) commented Jun 14, 2021

Copy link
Copy Markdown
Contributor

The TypeScript team hasn't accepted the linked issue #28491. If you can get it accepted, this PR will have a better chance of being reviewed.

Daniel Rosenwasser (DanielRosenwasser) requested changes Jun 15, 2021
View reviewed changes

Daniel Rosenwasser (DanielRosenwasser) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just want a bit more test coverage.

Comment thread tests/cases/fourslash/codeFixAddMissingProperties8.ts Outdated
Comment thread src/services/codefixes/fixAddMissingMember.ts
Comment thread tests/cases/fourslash/codeFixAddMissingProperties1.ts Outdated

Andrew Branch (andrewbranch) commented Jun 17, 2021

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) commented Jun 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the tarball bundle task on this PR at 5896e3b. You can monitor the build here.

TypeScript Bot (typescript-bot) commented Jun 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hey Andrew Branch (@andrewbranch), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/105173/artifacts?artifactName=tgz&fileId=C607D22BDB832E857D96A8EDE1088CB00C7D84B8C315BAC7837C2B5B7FCDFACA02&fileName=/typescript-4.4.0-insiders.20210617.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.4.0-pr-44576-3".;

Andrew Branch (andrewbranch) commented Jun 17, 2021

Copy link
Copy Markdown
Member

No playground link TypeScript Bot (@typescript-bot)? ☹️

Andrew Branch (andrewbranch) approved these changes Jun 17, 2021
View reviewed changes

Andrew Branch (andrewbranch) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

Daniel Rosenwasser (DanielRosenwasser) merged commit eee34d5 into microsoft:main Jun 17, 2021
Merged
Closed
5 tasks
This was referenced Oct 17, 2021
Closed
Closed
Harsh Pandey (hpx7) mentioned this pull request Feb 5, 2022
Closed
Harsh Pandey (hpx7) mentioned this pull request May 6, 2022
Closed
Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser approved these changes
Andrew Branch (andrewbranch) andrewbranch approved these changes
Wesley Wigham (weswigham) Awaiting requested review from weswigham

Assignees

No one assigned

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Declare all missing members quick fix

4 participants

Back | FazBrowse Home | New Git URL